[pull] main from adobe:main - #383
Merged
Merged
Conversation
* adding initial automated api diff process * tentative github action job * chromatic workflow and update token naming * maybe use github model since I dont have a anthropic token and update readme * lower permisisons * fix missing repo name in prompt * update readme * error messaging and simplification * try a dry run * trigger workflow test * tested differ, change channel for chromatic testing * whoops messed up the formatting * finished testing, confirmed behavior * actually need to test no diff detected case * fix fail due to diff having been already commited and dont push stder into diff file * empty commit, this should return nothing * handle case where new release happens runs and check last diff repo commit rather than just last week the latter is to handle the case where we run this flow multiple times a day or in the same week and there arent any new changes. Previously it would still use the current weeks diff results rather than reporting that there are no changes * add clarity for various diff cases running diff right after new release when there are new changes, running diff between releases, where there are no changes between last run, and when there are no changes from the released code * still got a diff message... try something else * invalid yarn option ugh * empty commit after new baseline, this should return nothing * done with testing * update readme and prompt * Apply suggestions from code review Co-authored-by: Daniel Lu <danilu@adobe.com> * make it clear to AI model that it comparing a diff of diffs hopefully this make it so it can reason that a new api change to a component/prop that didnt have changes last week isnt actually a brand new component
* chore: Format with oxfmt * Don't format codemod fixtures * Forgot to commit vscode settings
* docs: restore client side routing / RouterProvider section in frameworks.mdx ♜ The previous `routing.html` page covered `RouterProvider` setup in detail (general API, React Router, Next.js app/pages router, Remix, TanStack Router) but is no longer linked from the new docs and `react-aria.adobe.com/routing` returns 404. The new `frameworks.mdx` page only mentions `RouterProvider` in passing inside the React Router (framework mode) tab and does not explain how to set it up. This restores the old detailed routing content as a 'Client side routing' section at the top of `frameworks.mdx`, ahead of the existing locale and bundler tabs (now grouped under 'Locale and bundler setup'). Co-authored-by: Rook <rook@rook.is> * docs: split client side routing setup across framework tabs ♜ Move the framework-specific RouterProvider setup into the existing Next.js, React Router, and a new TanStack Router tab in frameworks.mdx, rather than as one long section above all tabs. - Keep a brief 'Client side routing' intro above the tabs covering the general RouterProvider API and routerOptions. - Next.js tab: App Router (RouterProvider in client provider, plus optional basePath/useHref) and a 'Pages router' subsection. - React Router tab: framework-mode RouterProvider wired into the root layout, plus 'Declarative mode' and 'Remix' subsections. - New TanStack Router tab documents the createLink approach (RouterProvider not needed). - Bundler tabs (Parcel/Vite/webpack/Rollup/ESBuild) unchanged. Co-authored-by: Rook <rook@rook.is> * docs: explain client side routing via render prop instead of RouterProvider ♜ Replace the dead ./frameworks link on the Link docs page with a new 'Client side routing' section showing the render prop pattern for Next.js and React Router. Update getting-started.mdx to point to the Link docs for routing setup instead of the frameworks page. Revert previous changes to frameworks.mdx and remove TanStackRouter icon. Co-authored-by: Rook <rook@rook.is> --------- Co-authored-by: Rook <rook@rook.is>
github-actions
Bot
added
FileTrigger
Form
GridList
Group
I18nProvider
IllustratedMessage
Image
InlineAlert
Link
ListBox
Menu
Meter
Modal
NumberField
Picker
Popover
ProgressBar
ProgressCircle
RadioGroup
RangeCalendar
RangeSlider
SearchField
SegmentedControl
Select
SelectBoxGroup
Separator
Slider
StatusLight
Switch
Table
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )